Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog 5.8: running changelog #8442

Merged
merged 49 commits into from Jan 30, 2018
Merged

Changelog 5.8: running changelog #8442

merged 49 commits into from Jan 30, 2018

Conversation

oskosk
Copy link
Contributor

@oskosk oskosk commented Jan 3, 2018

  • Updates changelog.txt to include 5.7's changelog
  • Updates readme.txt with boilerplate for 5.8's changelog.
  • Updates Stable tag to 5.7 (please update if there happens to exist a 5.7.1 release)

@oskosk oskosk requested a review from a team as a code owner January 3, 2018 00:15
@oskosk oskosk added this to the 5.8 milestone Jan 3, 2018
@oskosk oskosk added the General label Jan 3, 2018
readme.txt Outdated
@@ -5,56 +5,47 @@ Stable tag: 5.7.1
Requires at least: 4.7
Tested up to: 4.9

The one plugin you need for stats, related posts, search engine optimization, social sharing, protection, backups, speed, and email list management.
Hassle-free design, marketing, and security — all in one place.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not change this, it affects search results in the plugin directory. Also we should add "site search".

See https://wordpress.org/plugins/search/backups/ results for instance

* Release date: February 6, 2018
* Release post: https://wp.me/p1moTy-731

**Major Enhancements**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add search to Major Enhancements:

Search: Release from being in beta. Many improvements: customizer UX improvements; custom sorting support; post type filtering; and bug fixes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gibrown I'm still working on the changelog items and testing list for Search (quite a few more PRs to go through). I'd be happy to get your feedback on it when it's ready! I've just committed what I have so far, and will continue to add to it later today. Feel free to add to the testing list as well, or ping me.

Thank you!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeherve np, sorry for jumping the gun. Came across it looking for something else. :)

readme.txt Outdated
Stop worrying about data loss, downtime, and hacking. Jetpack provides:
* Site stats and analytics
* Automated social media posting and scheduling in advance
* Elasticsearch-powered related content and site search
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Site search and filters that give great results and scales to millions of posts."

@jeherve
Copy link
Member

jeherve commented Jan 30, 2018

@richardmuscat Could you review the feedback above about all the changes to the readme's wording? Thanks!

Copy link
Member

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @richardmuscat please can you get your eyes on this asap? We're merging now for the beta.

@zinigor zinigor dismissed gibrown’s stale review January 30, 2018 22:31

Thanks for reviewing! I removed changes to readme.txt, your other comments will be addressed after we roll out the beta.

@zinigor zinigor merged commit 1ee2c03 into master Jan 30, 2018
@zinigor zinigor deleted the add/changelog-58 branch January 30, 2018 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants