Merges changes to the GettyImages shortcode from WordPress.com. #8591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zinigor
added
[Type] Enhancement
jeherve
added
the
[Status] Needs Review
jeherve
reviewed
Jan 22, 2018
modules/shortcodes/getty.php
Outdated
| /** | ||
| * Context: http://wp.me/p5j4vm-1y7 | ||
| * | ||
| * @hide-in-jetpack |
There was a problem hiding this comment.
Looks like this made it in when it should not have?
This is a merge of changes from WordPress.com related to the new format of markup returned by GettyImages oembed endpoints. D9498-wpcom is the mirror change.
zinigor
force-pushed
the
merge/getty-shortcode
branch
from
5a107ce
to
7ee1e3c
Compare
aduth
previously requested changes
Jan 28, 2018
modules/shortcodes/getty.php
Outdated
| @@ -27,8 +27,8 @@ function jetpack_getty_enable_embeds( $site = 'wpcom' ) { | |||
| : 'wordpress.com'; | |||
|
|
|||
| // Support their oEmbed Endpoint | |||
| wp_oembed_add_provider( '#https?://www\.gettyimages\.com/detail/.*#i', "https://embed.gettyimages.com/oembed/?caller=$caller", true ); | |||
There was a problem hiding this comment.
This makes the $caller variable unused? Should probably be removed.
|
Thanks for taking a look, Andrew! I have fixed caller handling. |
dereksmart
approved these changes
Jan 30, 2018
jeherve
added
[Status] Has Changelog
and removed
[Status] Needs Changelog
[Status] Needs Review
zinigor
pushed a commit
that referenced
this pull request
Jan 30, 2018
* Changelog 5.8: create base for changelog. * Update 5.8 release post link * fix 5.8 release date * Updates to plugin description * Changelog: add #8499 * Changelog: add #8506 * Changelog: add #8509 * Changelog: add #8516 * Changelog: add #8517 * Changelog: add #8523 * Changelog: add #8547 * Changelog: add #8496 * Changelog: add #8584 * Changelog: add #8595 * Changelog: add #8445 * Changelog: add #8431 * Changelog: add #8284 * Changelog: add #8270 * Changelog: add #8124 * Changelog: add #8581 * Changelog: add #8463 * Changelog: add #8568 (#8646) * Updates to testing list and changelog * Changelog: add #8443 * Changelog: add #8459 * Changelog: add #8469 * Changelog: add #8464 * Changelog: add #8478 and #8479 * Changelog: add #8483 * Changelog: add #8488 * Changelog: add #8513 * Changelog: add #8555 * Changelog: add #8565 * Changelog: add #8601 * Changelog: add #8612 * Changelog: add first pass at Search items. * Changelog: add more info to help test Search. * Changelog: add #8144 * Changelog: add #8313 * Changelog: add #8419 * Changelog: add #8465 * Changelog: add #8515 * Changelog: add #8587 * Changelog: add #8591 * Changelog: add #8659 * Changelog: add #8661 * Changelog: add #8671 * Changelog: add 5.7.1 to archived changelog too. * Reverted changes to readme, removed entry about backups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a merge of changes from WordPress.com related to the new format of markup returned by GettyImages oembed endpoints. D9498-wpcom is the mirror change.
Fixes #8569
Testing instructions:
Make sure Getty Images shortcode works as expected in both ways:
[getty src="82278805" width="462" height="370"]Both ways should result in an embedded image.
Proposed changelog entry for your changes: