Support attachments with title, test and author #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer need to parse block quotes ourselves.
The only difference between the fork and upstream slackdown is multiline code blocks, i.e. triple backticks: ```something```. The markdown parser we're now using already has support for this.
The title is now linked.
psrpinto
force-pushed
the
message-attachments-2
branch
from
da8eac9 to
34c159b
Compare
I can't figure out why this was even being done. I can't find anything in the spec about edits in replies needing a fallback. Element doesn't do it either, if it's good for Element, must be good for us.
|
Just the failing test is prevening this from being merged, @psrpinto is working on fixing it. |
|
An interesting sideeffect of this is when you write Markdown on Slack, it will render as formatted on Matrix when bridged. (You can press cmd-shift-f in Slack to achieve formatting there) Remark: attachments in Slack are deprecated and the Block Kit should be used, we still need to add support for that. |
|
Wow, case-insensitive vs case-sensitive filesystem! |
|
Yep, noticed it by chance, turns out it was the issue. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves rendering of slack attachments. Not all fields are supported (e.g. images), but the most common ones should be.
This PR also includes some further refactors, and also fixes an issue that caused edits in threads to be posted as replies (upstream issue).
Additionally, we're now using a markdown parser, which simplifies a lot of things (e.g. don't need to parse blockquotes ourselves).
Screen captures
On Matrix
On Matrix, before this PR
On Slack