Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set external_url on messages sent to Matrix #3

Merged
merged 9 commits into from
Jun 22, 2023
Merged

Conversation

psrpinto
Copy link
Member

@psrpinto psrpinto commented Jun 22, 2023

This PR sets the external_url property on the matrix event, as per the spec:

Application services should include an external_url in the content of events it emits to indicate where the message came from. This typically applies to application services that bridge other networks into Matrix, such as IRC, where an HTTP URL may be available to reference.

The external_url property is set for both "normal" messages and messages in a thread:

  • https://${team.domain}.slack.com/archives/${slackRoomId}/p${slackEventTs}
  • https://${team.domain}.slack.com/archives/${slackRoomId}/p${slackEventTs}?thread_ts=${slackThreadTs}

@psrpinto psrpinto self-assigned this Jun 22, 2023
@psrpinto psrpinto marked this pull request as ready for review June 22, 2023 16:27
@psrpinto
Copy link
Member Author

Tested locally and seems functional, so merging.

@psrpinto psrpinto merged commit 061c6dd into develop Jun 22, 2023
@psrpinto psrpinto deleted the external-url branch June 22, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant