Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export command #4

Merged
merged 11 commits into from
Jun 30, 2023
Merged

Export command #4

merged 11 commits into from
Jun 30, 2023

Conversation

psrpinto
Copy link
Member

@psrpinto psrpinto commented Jun 30, 2023

Command for exporting the list of linked rooms and their corresponding Slack channel id, as a CSV file.

export - export the list of linked rooms and their corresponding Slack channel id, as a CSV file
  --file_name|-F - Name of the CSV file (optional)
  --team|-T - Filter only rooms for this Slack team domain (optional)

@psrpinto psrpinto changed the title Command for exporting the list of linked rooms and their corresponding Slack channel id, as a CSV file Export command Jun 30, 2023
@psrpinto
Copy link
Member Author

psrpinto commented Jun 30, 2023

@ashfame After our pairing session, I saw some opportunities for refactoring, so I went ahead and made them. I also made it possible to pass the name of the file as argument.

I've also renamed the column in the CSV file from bridged_matrix_room_id to matrix_room_id, since I think the "bridged_" is unnecessary. It also makes it consistent with the naming of the other column (slack_channel_id, as opposed to bridged_slack_channel_id). If this is ok with you, I guess you'll have to adapt the import tool accordingly.

@psrpinto psrpinto marked this pull request as ready for review June 30, 2023 15:13
@psrpinto psrpinto requested a review from ashfame June 30, 2023 15:13
@ashfame
Copy link
Member

ashfame commented Jun 30, 2023

Sounds good! No problem at all on changing the CSV header, I will change that in import tool documentation. Header actual names don't matter much.

@psrpinto psrpinto merged commit 1723b5e into develop Jun 30, 2023
@psrpinto psrpinto deleted the export-command branch June 30, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants