BREAKING CHANGE: remove connection noListener option
#15641
Merged
+4
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated noListener option from connection's useDb() method as part of a breaking change for version 9.0, since the option currently throws an error and is no longer functional.
- Removes
noListenerparameter documentation from JSDoc comments - Eliminates conditional logic that handled the
noListeneroption - Updates TypeScript test to remove usage of the deprecated option
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/connection.js | Removes JSDoc documentation for the deprecated noListener parameter |
| lib/drivers/node-mongodb-native/connection.js | Removes noListener parameter documentation and related conditional logic from useDb() implementation |
| test/types/connection.test.ts | Removes TypeScript test case that used the deprecated noListener option |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
hasezoey
approved these changes
Sep 23, 2025
AbdelrahmanHafez
approved these changes
Sep 23, 2025
vkarpov15
added a commit
that referenced
this pull request
Sep 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#15640 pointed out that the
noListeneroption currently throws an error, so we should remove support for that in 9.0Examples