Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mongodb driver version to 3.x #273

Merged
merged 14 commits into from
May 13, 2019
Merged

Update mongodb driver version to 3.x #273

merged 14 commits into from
May 13, 2019

Conversation

mpangrazzi
Copy link
Contributor

@mpangrazzi mpangrazzi commented May 7, 2019

Hi,

I've updated the mongo dep to ^3.2.3, following the changes reported here.

What I did so far:

I didn't implement or support any new features ATM (such as retryable writes or change streams).

All tests are passing, although there are some deprecation logs.
Since there are some breaking API changes, this could be a major version update.

@codecov-io
Copy link

codecov-io commented May 7, 2019

Codecov Report

Merging #273 into master will increase coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   94.57%   94.81%   +0.24%     
==========================================
  Files           6        6              
  Lines         387      386       -1     
==========================================
  Hits          366      366              
+ Misses         21       20       -1
Impacted Files Coverage Δ
lib/manager.js 95.48% <100%> (+0.87%) ⬆️
lib/collection.js 94.28% <100%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39228ea...5165a36. Read the comment docs.

@gflores
Copy link

gflores commented May 7, 2019

Please merge it soon, I really need the v3

Copy link
Collaborator

@mathieudutour mathieudutour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

lib/manager.js Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@mathieudutour mathieudutour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few comments in the docs and then I'll merge this

docs/collection/findOneAndUpdate.md Outdated Show resolved Hide resolved
docs/collection/findOneAndUpdate.md Show resolved Hide resolved
test/monk.js Show resolved Hide resolved
Copy link
Collaborator

@mathieudutour mathieudutour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@mathieudutour mathieudutour merged commit 387150d into Automattic:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Mongo 3.0.10 Add support for Mongo 3.6 connection strings
4 participants