-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed URL parsing of replsets #58
Conversation
Yes please 👍 |
Can you remove the |
Ah, yep I'll fix that tonight. I didn't even notice it did that. I just did |
nicer formatting anyway :D legacy comma-first days |
looks like the new mongoskin does this for you I think, or mongodb-native, can't read the damn code so it's hard to see wtf is going on but I'm going to try it with this stuff removed |
ok, would be nice to have this in |
Tests fail
|
To be valid, the connection string should be: |
As diorahman said, the connection string used in the test is not a valid mongodb connection string. Perhaps monk or mongoskin had translated it to something valid until now, but mongodb-url-parser intends to follow the official url spec. I guess it's up to you whether or not you want to break compatibility with that particular use--I don't suspect it's common--or revert. |
Fixes replset and auth parsing issues, as described in #19.