Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set hideAnswerFeedback default value to string #6623

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

gikaragia
Copy link
Contributor

There is an issue currently when creating new questions on a quiz. It is caused by setting the default value of hideAnswerFeedback to a boolean while it should be a string. To reproduce

Steps

  1. Go to a lesson
  2. Add a new question to a quiz
  3. Do not modify the question settings
  4. Click update

What I expected to happen

No error to occur

What happened instead

There is an error returned that complains that question does not pass validation.

Proposed Changes

  • Set all default values to strings.

@gikaragia gikaragia requested a review from a team March 9, 2023 10:09
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

WordPress Dependencies Report

The github-action-wordpress-dependencies-report action has detected some script changes between the commit a9a7bbf and trunk. Please review and confirm the following are correct before merging.

Script Handle Added Dependencies Removed Dependencies Total Size Size Diff
blocks/quiz/index.js 32.2 kB +2 B ( +0.01% 🔼 )

This comment was automatically generated by the github-action-wordpress-dependencies-report action.

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #6623 (a9a7bbf) into trunk (e18c666) will not change coverage.
The diff coverage is 58.49%.

Impacted file tree graph

@@            Coverage Diff            @@
##              trunk    #6623   +/-   ##
=========================================
  Coverage     48.29%   48.29%           
  Complexity    10011    10011           
=========================================
  Files           504      504           
  Lines         35642    35642           
  Branches        283      283           
=========================================
  Hits          17215    17215           
  Misses        18215    18215           
  Partials        212      212           
Impacted Files Coverage Δ
includes/class-sensei.php 27.12% <0.00%> (ø)
...i/class-sensei-rest-api-question-helpers-trait.php 86.96% <ø> (ø)
includes/class-sensei-list-table.php 45.79% <33.33%> (ø)
.../class-sensei-rest-api-setup-wizard-controller.php 69.58% <61.11%> (ø)
...ncludes/internal/emails/class-email-list-table.php 80.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab8ec16...a9a7bbf. Read the comment docs.

@onubrooks
Copy link
Contributor

onubrooks commented Mar 9, 2023

There is an error returned that complains that question does not pass validation.

Where is this error showing? I can't reproduce this part.

UPDATE: seen it.

@gikaragia gikaragia merged commit 4aa89ca into trunk Mar 9, 2023
@gikaragia gikaragia deleted the fix/question-default-value branch March 9, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants