Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.20.1 #7433

Merged
merged 9 commits into from
Jan 17, 2024
Merged

Release 4.20.1 #7433

merged 9 commits into from
Jan 17, 2024

Conversation

Imran92
Copy link
Contributor

@Imran92 Imran92 commented Jan 17, 2024

Release branch for 4.20.1

@Imran92 Imran92 requested a review from a team January 17, 2024 12:14
@Imran92 Imran92 self-assigned this Jan 17, 2024
@Imran92 Imran92 marked this pull request as ready for review January 17, 2024 12:14
Copy link

github-actions bot commented Jan 17, 2024

Please perform the following tests with the built package in a new installation before publishing:

  • Check that the installed version is correct on the Plugins page.
  • Create and publish a course, a module, and a lesson to the course.
  • Enable the learning mode in the course.
  • Log in with a user and complete the course.
  • Visit Students in admin and observe that the user is displayed with the course completed.
  • Disable learning mode in the course.
  • Visit the course again to make sure that it displayed correctly.

@Imran92 Imran92 added this to the 4.20.1 milestone Jan 17, 2024
@Imran92 Imran92 closed this Jan 17, 2024
@Imran92 Imran92 reopened this Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (179ff35) 51.21% compared to head (5692bc4) 51.20%.
Report is 110 commits behind head on trunk.

❗ Current head 5692bc4 differs from pull request most recent head 406e9ed. Consider uploading reports for the commit 406e9ed to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk    #7433      +/-   ##
============================================
- Coverage     51.21%   51.20%   -0.01%     
  Complexity    11184    11184              
============================================
  Files           614      614              
  Lines         47214    47220       +6     
  Branches        405      405              
============================================
  Hits          24179    24179              
- Misses        22708    22714       +6     
  Partials        327      327              
Files Coverage Δ
assets/shared/query-string-router/index.js 90.47% <100.00%> (ø)
includes/admin/class-sensei-setup-wizard.php 43.65% <ø> (ø)
...ask/class-sensei-home-task-create-first-course.php 47.36% <100.00%> (ø)
.../class-sensei-home-task-customize-course-theme.php 90.00% <100.00%> (ø)
...sk/class-sensei-home-task-publish-first-course.php 75.75% <100.00%> (ø)
...ludes/blocks/class-sensei-course-outline-block.php 93.75% <100.00%> (ø)
...locks/class-sensei-course-outline-course-block.php 83.87% <ø> (ø)
includes/class-sensei-course-structure.php 91.70% <ø> (ø)
includes/class-sensei-data-cleaner.php 87.75% <ø> (ø)
includes/class-sensei-lesson.php 36.20% <100.00%> (ø)
... and 18 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a497057...406e9ed. Read the comment docs.

m1r0
m1r0 previously approved these changes Jan 17, 2024
Copy link
Member

@m1r0 m1r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a very minor comment that is not a blocker.

"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"X-Generator: WP-CLI 2.9.0\n"
"X-Generator: WP-CLI 2.8.1\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No action on this PR is needed, just a friendly reminder to update your WP CLI. 😄

sensei-lms.php Show resolved Hide resolved
Otherwise we need to keep updating the years
@Imran92 Imran92 requested a review from a team January 17, 2024 14:03
@Imran92 Imran92 merged commit 6535ad7 into trunk Jan 17, 2024
22 checks passed
@Imran92 Imran92 deleted the release/4.20.1 branch January 17, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants