Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pendant: Templates: Single Post #5744

Closed
pbking opened this issue Mar 24, 2022 · 2 comments · Fixed by #5784
Closed

Pendant: Templates: Single Post #5744

pbking opened this issue Mar 24, 2022 · 2 comments · Fixed by #5784
Labels
[Status] Needs Design Approval This task needs a designer to approve the changes before it can be merged or marked complete. [Theme] Pendant

Comments

@pbking
Copy link
Contributor

pbking commented Mar 24, 2022 •
edited
Loading

image

image

Edit single.html to achieve the design. Ensure it works both with/out featured images.
@pbking pbking added this to the Pendant milestone Mar 24, 2022
PeterNdomano added a commit to PeterNdomano/themes that referenced this issue Mar 26, 2022
@PeterNdomano
Edited pendant/templates/single.html to meet the design suggested in …
b9e3e68 
…issue Automattic#5744
@PeterNdomano PeterNdomano mentioned this issue Mar 26, 2022
Merged
@pbking pbking mentioned this issue Mar 28, 2022
Merged
@pbking pbking added the [Status] Needs Design Approval This task needs a designer to approve the changes before it can be merged or marked complete. label Mar 31, 2022
@pbking
Copy link
Contributor Author

pbking commented Mar 31, 2022

Keeping this open until design can give a 👍

@pbking pbking reopened this Mar 31, 2022
@pbking
Copy link
Contributor Author

pbking commented Apr 1, 2022

Closing, will seek design review stage instead of approval.

@pbking pbking closed this as completed Apr 1, 2022
@pbking pbking mentioned this issue Apr 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Status] Needs Design Approval This task needs a designer to approve the changes before it can be merged or marked complete. [Theme] Pendant
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pendant: Template: Single Automattic/themes
1 participant
@pbking