Pendant: Template: Single #5784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbking
added
[Theme] Pendant
[Status] Needs Design Approval
Comment on lines
-2
to
-7
| "version": 2, | ||
| "templateParts": [ | ||
| { | ||
| "name": "header", | ||
| "area": "header" | ||
| }, |
There was a problem hiding this comment.
Is this happening because of the spaces to tabs change?
pbking
force-pushed
the
add/pendant-single
branch
from
62b7d32 to
f981bfb
Compare
|
Going to bring this in but leave the associated issue open for final design review. |
| "radius": "0px" | ||
| }, | ||
| "color": { | ||
| "background": "var:preset|color|foreground", |
There was a problem hiding this comment.
@pbking @MaggieCabrera would either of you be able to please point me to how/what this syntax is doing please? var:preset|color|foreground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May fix: #5744
Started by @PeterNdomano here.
This has a dependence on #5755 which should come in first.
Changes proposed in this Pull Request:
Adds an increased Header size to achieve target design for Single Page.
(Note: The [Page Title] block renders an H2 element, but the design called for the size shown for H1. To compensate I increased the size of H1 and backfilled the sizes from H4. This way the natively rendered H2 element hits the design. Please let me know if that's OK for the design.
I have also converted all of the units from px to rems in this process.
Before:
After:
Everything else was achievable using either Global Styles or Block-level configuration in the FSE.
Gap sizes are approximate compared to the figma design, however the implementation is simply constructed and scales dynamically. Hopefully the spacing suits.
Desktop With Featured Image
Mobile With Featured Image
Desktop Without Featured Image
Mobile Without Featured Image