Feelin'Good: Prepare for the submission. #7770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview changesI've detected changes to the following themes in this PR: Feelin'Good. You can preview these changes by following the links below: I will update this comment with the latest preview links as you push more changes to this PR. |
mikachan
approved these changes
Apr 26, 2024
|
@mikachan Thanks for reviewing and merging this. This doesn't seem to be deployed to WP.com, so there are no edits on the version number and readme.txt. Do I need to do anything else? |
Maybe, did you expect me to run |
|
We need to run a deploy but there are multiple theme changes queued up, so I'm currently seeing if they can all be deployed at once. It's looking fine I think so this should be deployed soon. |
|
OK, thank you for clarifying! |
|
This has been deployed now! |
|
Hmm, but no update has been made to the readme.txt, and the version number hasn't increased. Why do you think that is? The deploy process should take care of it, no? |
|
Yes, the deploy process takes care of that. The readme.txt was updated here with a version bump and changelog update: 738fb07#diff-c0a3fdf16f8cbe4c3fce1dc791968145987dd6dab5e10a8ed46643dc6916215e |
|
Oh!? I see them updated now. That's good, I wondered why I couldn't see them when I posted the last comment. Have you experienced something like this? |
Not specifically like this, but I'm wondering if you checked the files before the version bump was pushed maybe? |
|
Okay, I'm not sure what happened. Anyway, thank you! |
vcanales
added a commit
to vcanales/themes
that referenced
this pull request
May 24, 2024
* Prepare Archivo for dotorg submission (Automattic#7489) * Archivo: Prepare for the dotorg submission * Archivo: Added new templates and patterns for Woo * Archivo: Custom Template declaration * Archivo: Update heading type sizes * Archivo Update the min version * Version Bump * Archivo: Remove hard-coded link (Automattic#7495) * Version Bump * Messagerie: update variations (Automattic#7502) * Programme: add design updates (Automattic#7474) * Update assets and styles to new versions * Update 404 pattern and template * Remove big header pattern * Update templates to new versions * Fix custom-futura colors * Version Bump * Fix Ritratto and Magalog (Blogorama) (Automattic#7506) * Remove variation. * Update styles and variations * Rename to blogorama. * Fix image refs and escape text. * Version Bump * Update single.html (Automattic#7422) Add comment form to single posts. * Version Bump * Kaze: Add theme (Automattic#7510) Add the new Kaze theme - it is a WP.com exclusive Archivo spin-off, see pNEWy-hGU-p2 --------- Co-authored-by: Dean Sas <dean.sas@automattic.com> * Epi: Add theme (Automattic#7511) Add the new Epi theme - it is a WP.com exclusive Archivo spin-off, see pNEWy-hGU-p2 --------- Co-authored-by: Dean Sas <dean.sas@automattic.com> * Mysa: Add theme (Automattic#7512) Add the new Mysa theme - it is a WP.com exclusive Archivo spin-off, see pNEWy-hGU-p2 --------- Co-authored-by: Dean Sas <dean.sas@automattic.com> * Pomme: Add theme (Automattic#7513) Add the new Pomme theme - it is a WP.com exclusive Archivo spin-off, see pNEWy-hGU-p2 --------- Co-authored-by: Dean Sas <dean.sas@automattic.com> * Epi: Add strict types declaration to cart * Varia: Include Jetpack Content Options (Automattic#7518) * Varia: Fix Jetpack Content Options * Ensure options take effect * Assembler: Add theme (Automattic#7528) * Assembler: Fix php warnings (Automattic#7529) * Beep: Add theme (Automattic#7514) * Beep: Add theme * Beep: Fix the colour of footer template parts * Beep: Cleanup style variation and improved search no result page. * Indice: Add theme (Automattic#7521) * Index: Add theme * Indice: rename the theme to Indice * Indice: fix a typo * Indice: Add fonts credits to readme * Ici: Add theme (Automattic#7522) * Ici: Add theme * Ici: Lock footer text * Spiel: Add theme (Automattic#7531) * Xanadu: Add theme (Automattic#7533) * Version Bump * Add strict types declaration (Automattic#7534) Deploy script won't allow themes to be commited without this declaration. Recent previous case: Automattic#7529 * Assembler: fix font name casing for Rubik (Automattic#7541) * Allez: add theme (Automattic#7544) * Initial theme. * Remove refs and escape. * Remove unused image. * Update front-page pattern. * Add index and header patterns. * Shhh: Add theme (Automattic#7545) * Beep: Add strict types to remaining php files (Automattic#7546) * Xanadu: Add strict types to remaining php files (Automattic#7549) * Ici: Add strict types to remaining php files (Automattic#7548) * Indice: Add strict types to remaining php files (Automattic#7547) * Version Bump * Remove undeployed version of Spiel * Spiel: re-add and fix translator comment * Version Bump * Revert "Remove undeployed version of Spiel" This reverts commit 2f6edbd. * Version Bump * Spiel: fix style.css file merge conflict * Spiel: fix merge conflict * Add templates to Assembler (alternate) (Automattic#7538) * Add edits * Add page w title template * CBT export * Create search.html * Version Bump * Assembler: Fixing minor issues (Automattic#7555) * Update template-page-w-title.php Add strict type declaration. * Update theme.json Add comments template part declaration. * Updates from theme export (Automattic#7560) * Version Bump * Update index.html This is meant to fix the issue described in Automattic#7550 * Update theme.json Rubik font was default inadvertently. This fixes the theme to use the correct font. * Default featured images to false and leverage theme mod values that have already been set (Automattic#7567) * Default featured images to false and leverage theme mod values that have already been set * defaulting all options to be available, defaulting page display to false (or previous theme mod value) Co-authored-by: Aurorum <43215253+Aurorum@users.noreply.github.com> * Version Bump * fg2 is not always set (Automattic#7569) * Fixed a few minor issues with 'mpho' index template: removed 'theme' attribute and re-leveraged existing 'no-results' pattern (Automattic#7571) * Trellick: Submission Preps (Automattic#7570) * Spiel: Edit readme (Automattic#7554) * Assembler: Remove unneeded ref (Automattic#7576) * Block Canvas: Update header alignment (Automattic#7575) * radcliffe-2: PHP 8.1 updates from wpcom (Automattic#7584) * Minor tweaks for Assembler (Automattic#7583) * Fix spacing * Adjust button, colors, typography * Improve comments * Fix formatting * Fix typo * Add missing fonts to theme.json * Version Bump * Update theme erma (Automattic#7565) * Changes from WordPress Playground * Remove nav ref * Rename wp-custom-template-center-aligned-post.html --------- Co-authored-by: Sarah Norris <sarah@sekai.co.uk> * Update theme ron (Automattic#7563) * Changes from WordPress Playground * Remove nav refs * Remove reference to local URL --------- Co-authored-by: Sarah Norris <sarah@sekai.co.uk> * Version Bump * altofocus: Sync changes from D133939 (Automattic#7595) * Azur: Initial commit (Automattic#7579) * Version Bump * Bump follow-redirects from 1.15.1 to 1.15.4 (Automattic#7597) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.1 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.1...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Indice: Make the footer is always at the bottom of the viewport (Automattic#7594) * Strand: A round of updates. (Automattic#7582) * Update theme.json Fix the subscribe button width issue with css until it's fixed in Jetpack. * Update templates Update theme templates to add custom CSS class. * Update screenshot.png * Update footer widgets Minor updates to the content of the footer widgets. * Update theme.json Remove system font. Make headings bold. * Add strict type declarations. * Update footer widgets Update the copy of the About section. * Added a utility to pull changes to all themes from sandbox (Automattic#7573) * Version Bump * Assembler: Another round of tweaks (Automattic#7586) * Add custom css for growing (headers) * Remove locking from page template * Update font assets * Add font families to theme.json * Clean up * Fix * Add PT-Serif and Fraunces fonts * Create .gitignore * Clean up fonts * Fix button * Fix for social currentColor * Version Bump * Bedrock: Initial commit (Automattic#7578) * Bedrock: Initial commit * Bedrock: Add role atribute for sites without Gutenberg plugin * Version Bump * Bedrock: add missing strict types declaration (Automattic#7600) * Bedrock: use webp images (Automattic#7601) * Version Bump * Remove Bedrock temporarily (Automattic#7605) * Re-add bedrock. (Automattic#7606) * Bedrock: Initial commit * Bedrock: Add role atribute for sites without Gutenberg plugin * Bedrock: add missing strict types declaration --------- Co-authored-by: Takashi Irie <takashi@automattic.com> * Version Bump * lodestar: Sync D134558: Handle the case where there is no featured image (PHP 8.1 Warning) (Automattic#7609) * Add new theme Hall (Automattic#7319) * Adding new theme Hall from @henriqueiamarino * Removed 'theme' attribute * Removed 'ref' attributes from navigation * Removed unused pattern * Cleaned up theme.json file (saved via CBT) * Set version to 1.0.0 * Fixed Header templates to use Site Title instead of Header. Styled Site Title to match Header block that was removed. * Updates from latest zip * Update image refs in readme * Add strict_types * Patternise 404 and home templates --------- Co-authored-by: Sarah Norris <sarah@sekai.co.uk> * Version Bump * Assembler: Another round of tweaks (Automattic#7602) * Adjust heading line height, button sizes, spacing * Better social link sizes * Always use line-height 1 for xxl font size * Try with the first p in entry content have margin * Add more specificity to social links * Make small font size a bit smaller * Create 404.html * Update archive.html * More post template work * Remove comments part (its in the single) * Add style for core/separator * Update theme.json * Fix templates * Translation functions * Version Bump * Negai: Prepare the theme for the submission (Automattic#7611) * Version Bump * Dara: Fix TikTok Embed Block (Automattic#7481) * Dara: Fix TikTok Embed Block * Target videos only * Version Bump * Add Nook (Automattic#7557) Initial commit. * Add Craftfully (Automattic#7558) Initial commit. * Assembler: Fonts, text balance, field styling (Automattic#7617) * Add Fahkwang and Roboto * Organize stylesheet + add progressive text wrap * Tweak small * Create screenshot.png * Add jetpack form styles * Version Bump * Remove styles folder (Automattic#7621) Remove styles folder that was included by mistake. * Delete wp-custom-template-qi-blocks-full-width.html template (Automattic#7622) * Version Bump * Nook: A round of minor fixes (Automattic#7626) * Delete wp-custom-template-qi-blocks-full-width.html template * Update functions.php Update function names. * Update style.css * Remove theme.json instrument serif (Automattic#7629) * Version Bump * Multiple Themes: Fix broken template previews due to site specific attributes in template/pattern markup (Automattic#7631) * Remove site-specific taxQuery attributes * Remove site-specific navigation ref attribute * Hide jetpack and core patterns (Automattic#7633) * Version Bump * Unregister Jetpack form patterns on atomic sites (Automattic#7634) * Version Bump * Cakely: Add theme (Automattic#7632) * Cakely: Add theme * Version Bump * Bedrock: Make sure page navigation button has no underline on hover and focus states (Automattic#7618) * Version Bump * Freddie: Submission preps (Automattic#7627) * Version Bump * Exmoor: updates for the theme review (Automattic#7628) * Version Bump * Assembler: Try better spacing (Automattic#7642) * use standard spacingSizes from 20-80 * 20 is the new 10 * Update spacing * Update theme.json * Version Bump * Assembler: Minor spacing and button margin styling (Automattic#7643) * Add spacing for columns, margin for button * Add overflow-hidden utility * Version Bump * Kansei: Add theme (Automattic#7638) * Perenne: Add theme (Automattic#7640) * Perenne: Add theme * Perenne: Minor adjustments * Perenne: Minor adjustments * Chanson: Add theme (Automattic#7645) * Bedrock: Imporve post navigation with arrow (Automattic#7650) * Low Fi: Add theme (Automattic#7652) * Perenne: remove period from version (Automattic#7653) * Guard against improperly formatted dates (Automattic#7654) * Version Bump * Manually bumping foam to 1.0.2 (Automattic#7658) v1.0.1 bundles the old version of the wpcom theme updater which has PHP8 incompatibilities, bumping the version will allow a new zip to be generated which will bundle the new PHP8 compatible version of the wpcom theme updater. See Automattic#7657 for more details. * Version Bump * Feelin Good: Add theme (Automattic#7637) * Feelin Good: Add theme * Feelin' Good: Letter spacing adjustment * Feeling' Good: More letter spacing adjustments * Feelin' Good: Fix cover block markup * Kansei: Fix query pagination (Automattic#7656) * Feelin good: Add strict types to footer (Automattic#7659) * Version Bump * Infield: Add theme. (Automattic#7556) * Add Infield theme. Initial commit. * Removed unused font asset --------- Co-authored-by: Jason Crist <jcrist@pbking.com> * Version Bump * Lettre: round of fixes (Automattic#7664) * Add search template Add missing search template, including a "no-results" message. See Automattic#7662 * Update theme.json Add values to top and bottom spacing to fix the mobile nav spacing issues. See Automattic#7662 * Update archive.html Add query navigation on the archive pages. See Automattic#7231 * Update style.css * Add spacing to comment reply heading * Try fixing the underline issue in navigation * Add spacing to the search input field, to bring the styling in line with subscription block. * Version Bump * Update hidden-no-results-content.php (Automattic#7668) Add strict types declaration. * Craftfully: Fix issues with sidebar (Automattic#7669) * Update posts-list.php Remove reference to theme name because it's breaking the sidebar. * Update sidebar.php Fix block errors in the editor. * Update header.php Update the column alignment. * Version Bump * Lettre: Navigation styling fixes (Automattic#7670) * do not clear underline on hover * do not clear underline for current item * Version Bump * Stage: update style variations (Automattic#7501) * Lossless image optimization (Automattic#7671) * Lossless image optimization (using ImageOptim). This shouldn't change the visual appearance of any images. ImageOptim was run with the highest compression setting except that JPEG metadata stripping was disabled because some users prefer to avoid stripping JPEG metadata. * Update READMEs that have Changelogs for themes impacted by lossless image optmization change. * Feature: frontend improvements (Automattic#7692) * Fix unnecessary padding in outline buttons (Automattic#7462) * add body class in editor (Automattic#7465) * Add changelog * Bump version * Change version to 1.3.6 * Deploy script: Improve npm versioning step (Automattic#7694) * Remove package-lock step from individual theme updates * Remove silent from npm version bump * Assembler: Lint styles (Automattic#7686) * Linting styles * Lint styles * Update theme fewer (Automattic#7702) * Changes from WordPress Playground * Remove .DS_Store file --------- Co-authored-by: Sarah Norris <sarah@sekai.co.uk> * Changes from WordPress Playground (Automattic#7703) * Update readme.txt * Update readme.txt * Update readme.txt * Update style.css * Version Bump * pub themes: Restore changes overwritten from latest themes deploy (D144213 D144218 D144223 D144228 D144234 D144240 D144244) (Automattic#7708) * Bedrock: Move template parts from patterns and add them to templates (Automattic#7680) * Low Fi: Remove the patch version for submission (Automattic#7691) * Fotograma: Preps for submission (Automattic#7690) Co-authored-by: Sarah Norris <sarah@sekai.co.uk> * Bute: Preps for submission (Automattic#7667) Co-authored-by: Sarah Norris <sarah@sekai.co.uk> * Version Bump * Update readme.txt * Assembler: Add color and typography variations (Automattic#7710) * Ignore the assembler colors and typesets repo * Add color and typography variations * Version Bump * Adding a change just for redeploy (Automattic#7714) * Version Bump * Portia: Add theme (Automattic#7678) * Kentwood: Add theme (Automattic#7679) * Kentwood: Add theme * Kentwood add strict_types to all the php files * Fotograma: Update some default images and contents for submission (Automattic#7713) * Updates from @henriqueiamarino (Automattic#7712) Co-authored-by: henriqueiamarino <103748085+henriqueiamarino@users.noreply.github.com> * Version Bump * Fotograma: add strict types (Automattic#7715) * Add standard spacing presets to Block Canvas (Automattic#7717) * Version Bump * Fontaine: Add theme (Automattic#7707) * Fontaine: Add theme * Fontaine: fixed typos * Fontaine: provide easier footer template part customisation and change link styles * Version Bump * Block Canvas: Remove patterns (Automattic#7214) * remove footer pattern * Remove 404 patterns * Remove comments patterns * Remove theme attributes --------- Co-authored-by: Sarah Norris <sarah@sekai.co.uk> * Low Fi: Remove the space in the theme display name. No change in the slug and the textdomain. (Automattic#7730) * Version Bump * Assembler: Add fonts (Automattic#7729) * Add fontFaces, add basic caption styling, tweak theme-2 * Add DM Mono * Add Lucette * Add Messapia * Add DM Mono light and heading link style * Assembler: Update bundled color and typography theme styles (Automattic#7731) * update styles * Update 40-eclipse.json * Add colorway-1 to parent (dark) * Version Bump * Jazzers: add theme (Automattic#7279) * Jazzers: add theme * remove table styles * Remove theme attribute from template part calls * Add updates from latest zip * update files * Add strict types --------- Co-authored-by: Sarah Norris <sarah@sekai.co.uk> * Version Bump * Portia: Prepare for WP.org submission (Automattic#7739) * Version Bump * Portia: changed the theme URI (Automattic#7740) * Version Bump * Fontaine: Fix hardcoded links, changed theme URI, and fix textdomain errors (Automattic#7741) * Version Bump * Add a script that inserts strict type declarations (Automattic#7716) * Add a scripts that adds strict type declarations Checks all php files in a given directory for existing strict type declartions, and if it doesn't find one, adds it. * add strict types on deploy * add missing quotes * Added npm command to trigger strict type additions and passed 'last deployed hash' to get changed themes * fixed bash command and added error catching so errors won't stop deployment * Add condition for debug output --------- Co-authored-by: Jason Crist <jcrist@pbking.com> * Kiosko: add theme (Automattic#6905) * Initial commit. * Removed theme reference from template part blocks * updated wordpress tested version * Removed table styles (fixed in gutenberg) * Update theme patterns Adding the strict types declaration, plus two additional store-related patterns. * Removing templates Removing these store templates as there's no difference between this and the fallback store archive template. * Update WooCommerce-specific templates Replacing legacy template with specific WooCommerce blocks. * Update readme.txt --------- Co-authored-by: Jason Crist <jcrist@pbking.com> Co-authored-by: alaczek <ola@bodera.com> * Version Bump * Fix custom heading background style. (Automattic#7751) Move custom CSS from the theme.json to style.css and apply color variables, so that it works better with color variations. * Version Bump * Luminance: Update it for submission (Automattic#7735) * Luminance: Update it for submission * Luminance: Add php strict mode statements * Version Bump * Replace screenshot.png The WP.org theme review requires screenshot to be 1200x900px, and it is currently 2400x1800px. * Version Bump * Surrealist: Add theme (Automattic#7732) * Surrealist: Add theme * Surrealist: Added Post Comments Link Style * Surrealist: Added Post Comment Count Style * Surrealist: Change theme URI * Update screenshot.png The previous theme screenshot had the wrong dimensions to launch on WP.org. * Update style.css Removed repeated tags. * Raw: Update screenshot (Automattic#7761) * Update screenshot for Raw * Use newer screenshot * Version Bump * Removes logo resize reset testing code (Automattic#7760) * Version Bump * Update theme.json (Automattic#7768) This fixes wrongly set default font "Rubik" and replaces it with the correct font "Albura". * Version Bump * Generate playground previews for themes (Automattic#7719) Co-authored-by: Sarah Norris <sarah@sekai.co.uk> * Update theme foam (Automattic#7769) * Update comments template to match latest Gutenberg block markup (Automattic#7736) * Update comments pattern markup * Tweak avatar and comment styling in theme.json * Update versions and change log * Version Bump * Feelin'Good: Prepare for the submission. (Automattic#7770) * Feelin'Good: Prepare for the submission. * Feelin'Good: more clean up * Update readme.txt Adds theme screenshot image sources and licenses. * Prepare theme for WP.org submission (Automattic#7759) * Use pull_request_target to avoid token restriction (Automattic#7771) Due to restrictions imposed to the `GH_TOKEN` when forks are created from forks when workflows are triggered by the pull_request event, I'm switching the execution to be done on `pull_request_trigger`, which lifts said restrictions. Docs: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target > This event runs in the context of the base of the pull request, rather than in the context of the merge commit, as the pull_request event does. This prevents execution of unsafe code from the head of the pull request that could alter your repository or steal any secrets you use in your workflow. This event allows your workflow to do things like label or comment on pull requests from forks. Avoid using this event if you need to build or run code from the pull request. * make sure workflow runs on PR base branch (Automattic#7772) wip checkout pr branch and fetch origin e * Radcliffe 2 & Photos: Revert SVG icon files (Automattic#7773) * Revert icons.svg after image compressing * Restore icons in photos theme * Update theme upsidedown-update (Automattic#7721) * Workflow security issue (Automattic#7778) * split workflow; checkout create-preview-links from trunk * split changed themes by , * revert test values * Revert to using `pull_request` as the event trigger (Automattic#7782) * Dara: move away from deprecated class (Automattic#7783) * Version Bump * Negai: update to 1.0.4 (Automattic#7779) * Negai: Improve duotone experience, cleanup custom css * Megai: Revert accidental changes in irrelevant file * Replace foreground with contrast (Automattic#7787) * Cakely: Cleanup for submission (Automattic#7784) * Version Bump * Update readme.txt Adds correct image license. * Replace screenshot.png * Update readme.txt Add correct font license. * Update style.css * replace not needed esc_html_x by __ * remove not necessary fix (Automattic#7792) * Cakely: Fixed submenu colours, and added a link to Midjourney's TOS page to readme.txt (Automattic#7794) * Cakely: Fixed submenu colours, and added a link to Midjourney's TOS page in readme.txt * Cakely: Added a link to Midjourney's TOS page in readme.txt * Version Bump * Troner: Update for submission (Automattic#7795) * Tronar: Clean-up and minor adjustments for submission * Tronar: Update the version number for 'tested up to' * Version Bump * Update screenshot.png Updates theme screenshot with the correct size. * Update readme.txt * OnyxPulse: Add theme (Automattic#7793) * OnyxPulse: Add theme * OnyxPulse: Minor style adjustment * Dark Academia: Add theme (Automattic#7802) * Version Bump * Revert "Update theme upsidedown-update (Automattic#7721)" (Automattic#7821) This reverts commit 3acd95b. Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com> * Version Bump * OnyxPulse: Reduce the file size of the screenshot and adjusted the theme tags. (Automattic#7822) * Version Bump * OnyxPulse: Adds strict type (Automattic#7823) * Version Bump * Spiel: Clean up for Dotorg submission, Added a spacingSize20, and removed some unnecessary local styling from templates. (Automattic#7804) * Version Bump * Get latest hash from github tag instead of sandbox * Add version bump workflow --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Takashi Irie <takashi@automattic.com> Co-authored-by: madhusudhand <madhusudhan.dollu@gmail.com> Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com> Co-authored-by: Sarah Norris <sarah@sekai.co.uk> Co-authored-by: Jeff Ong <jonger4@gmail.com> Co-authored-by: alaczek <ola@bodera.com> Co-authored-by: Dean Sas <dean.sas@automattic.com> Co-authored-by: Aurorum <43215253+Aurorum@users.noreply.github.com> Co-authored-by: Ashar Fuadi <fushar@gmail.com> Co-authored-by: Rich Tabor <hi@richtabor.com> Co-authored-by: Beatriz Fialho <65220155+beafialho@users.noreply.github.com> Co-authored-by: Jason Crist <jcrist@pbking.com> Co-authored-by: Ben Dwyer <ben@scruffian.com> Co-authored-by: Matthew Reishus <mreishus@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Miguel <miguel.san.segundo@automattic.com> Co-authored-by: Miguel San Segundo <1881481+miksansegundo@users.noreply.github.com> Co-authored-by: Przemek Kuliga <pkuliga@gmail.com> Co-authored-by: Dan Luu <danluu@gmail.com> Co-authored-by: Imran Hossain <imranh920@gmail.com> Co-authored-by: henriqueiamarino <103748085+henriqueiamarino@users.noreply.github.com> Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> Co-authored-by: Grant Kinney <creativecoder@users.noreply.github.com> Co-authored-by: Grant Kinney <hi@grant.mk> Co-authored-by: Donna Peplinskie <donnapep@gmail.com> Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request: