Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme-utils: Update to use internal GitHub #7972

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Conversation

ehg
Copy link
Member

@ehg ehg commented Jul 25, 2024

This changes all usage of arc to GitHub's gh utility.

I haven't tested this, and I'm not quite sure how to – but I'm pushing it as a starting point. Maybe someone could set up gh on their sandbox and give it a spin?

To set up gh:

  • Login to your sandbox
  • Run gh auth login and follow the instructions.

ehg added 3 commits July 25, 2024 12:26
This changes all usage of `arc` to GitHub's `gh` utility.

I haven't tested this, and I'm not quite sure how to – but I'm pushing
it as a starting point.
@Copons Copons requested review from dsas, miksansegundo and alaczek July 25, 2024 12:20
theme-utils.mjs Outdated Show resolved Hide resolved
@miksansegundo
Copy link
Contributor

I have added changes to allow us testing the deploy process.

Steps for testing:

  • checkout this branch in local
  • run npm run deploy
  • you are supposed to deploy from trunk but that check is skipped
  • follow the prompts

I have only tested until the PR step and created a deploy PR during testing.

theme-utils.mjs Outdated Show resolved Hide resolved
Also restore changes used to develop these changes
Copy link
Contributor

@dsas dsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to be merged. I tested until and including a deploy pub outnow;exit;

@dsas dsas merged commit c432aeb into trunk Jul 30, 2024
2 checks passed
@dsas dsas deleted the try/update-for-github branch July 30, 2024 08:14
@dsas
Copy link
Contributor

dsas commented Jul 30, 2024

Updated the existing theme deployment howto PNEWy-eqL-p2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants