Tweak rootHasVersionBump logic #8019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| console.log('No changes detected; version bump not required'); | ||
| } | ||
|
|
||
| if (versionBumpCount > 0 && rootHasVersionBump) { |
There was a problem hiding this comment.
I have had to update this logic because otherwise the version wasn't bumped when theme changes are made. See 2ba4dd2#diff-877b4284538ebb4cf1411cf4487c456bda52082b9e72e4a0b6770d5a80d7d5a9R677
versionBumpCount is a count for the theme bumps done for changed themes.
rootHasVersionBump is a boolean that tell us if the root package version has changed from the previews release tag.
Therefore, we can skip the root package bump only when versionBumpCount === 0 and we must bump it when it's not done yet rootHasVersionBump === false.
cc: @dsas
There was a problem hiding this comment.
Thanks @miksansegundo 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Tweaks the version bump logic so the root project version is only bumped if there are changes.
Hopefully prevents unnecessary version bumps from happening, like this: #8018