Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive fixes #401

Merged
merged 5 commits into from
May 14, 2024
Merged

Responsive fixes #401

merged 5 commits into from
May 14, 2024

Conversation

djalmaaraujo
Copy link
Contributor

Description

A few responsive fixes for the dashboard and general stuff:

  • Making the first breaking as 0px. This ensures we have the same behavior from 0px to the second breakpoint. Without this, the minimum breakpoint is 320, so the responsiveness is gone < 320px;

There are just a few devices with 320px or lower, the last one being released in 2013, but it still makes sense to allow responsiveness for smaller devices.

Noting that we only need to support 320px and above since this is required for WCAG Reflow https://www.w3.org/WAI/WCAG21/Understanding/reflow.html/

  • Avoid shrinking the VIP Dashboard logo and mobile trigger button;

Checklist

  • This PR has good automated test coverage
  • The storybook for the component has been updated

Steps to Test

These are just style changes.

@djalmaaraujo djalmaaraujo requested review from a team May 14, 2024 21:40
Copy link

netlify bot commented May 14, 2024

Deploy Preview for vip-design-system-components ready!

Name Link
🔨 Latest commit 0a3dd45
🔍 Latest deploy log https://app.netlify.com/sites/vip-design-system-components/deploys/6643da8c19b1ed0008493f57
😎 Deploy Preview https://deploy-preview-401--vip-design-system-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@djalmaaraujo djalmaaraujo force-pushed the responsive/add-0-for-breakpoints branch from d94d2a0 to 0a3dd45 Compare May 14, 2024 21:41
@djalmaaraujo djalmaaraujo changed the title Responsive/add 0 for breakpoints Responsive fixes May 14, 2024
Copy link
Contributor

@kat3samsin kat3samsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@djalmaaraujo djalmaaraujo merged commit 5d5804e into trunk May 14, 2024
8 checks passed
@djalmaaraujo djalmaaraujo deleted the responsive/add-0-for-breakpoints branch May 14, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants