Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs and link style update #404

Merged
merged 5 commits into from
May 23, 2024
Merged

Conversation

djalmaaraujo
Copy link
Contributor

@djalmaaraujo djalmaaraujo commented May 20, 2024

Description

  • Updating Breadcrumbs with a new variant (collapsible). You can define by using wrapMode property.
  • Updating link styles

Checklist

  • This PR has good automated test coverage
  • The storybook for the component has been updated

Steps to Test — Breadcrumbs

USING THE KEYBOARD

  1. Pull down PR.
  2. npm run dev.
  3. Open http://localhost:6006/?path=/story/navigation-breadcrumbs--collapsible
  4. Reduce screen size to make the breadcrumb wraps
  5. Verify the three dots button is available. Press the button, the focus should be on the following link

Steps to Test — Link

  1. Pull down PR.
  2. npm run dev.
  3. Open http://localhost:6006/?path=/story/navigation-link
  4. Notice that the underline is smaller
  5. The hover underline is stronger

Copy link

netlify bot commented May 20, 2024

Deploy Preview for vip-design-system-components ready!

Name Link
🔨 Latest commit e62cf6c
🔍 Latest deploy log https://app.netlify.com/sites/vip-design-system-components/deploys/664f3cf61c5dd20008ebfd2d
😎 Deploy Preview https://deploy-preview-404--vip-design-system-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@djalmaaraujo djalmaaraujo requested review from a team May 20, 2024 20:48
@djalmaaraujo djalmaaraujo changed the title Breadcrumbs update: Revamp with wrapMode Breadcrumbs and links update May 23, 2024
@djalmaaraujo djalmaaraujo changed the title Breadcrumbs and links update Breadcrumbs and link style update May 23, 2024
Copy link
Contributor

@brunobasto brunobasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚢

@djalmaaraujo djalmaaraujo merged commit e45e92c into trunk May 23, 2024
8 checks passed
@djalmaaraujo djalmaaraujo deleted the responsive/breadcrumbs-update branch May 23, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants