Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Migration: Dropdown, FilterDropdown, Page, Hr #416

Merged
merged 8 commits into from
Jun 27, 2024

Conversation

djalmaaraujo
Copy link
Contributor

@djalmaaraujo djalmaaraujo commented Jun 26, 2024

Description

This is part of a bigger initiative to migrate as many generic components as possible from the VIP Dashboard to this library. This PR includes:

  • Dropdown (Convert to TS);
  • FilterDropdown
  • Page (For now, it's a simple box replacement). Next, PRs will have more.
  • Hr

Checklist

  • This PR has good automated test coverage
  • The storybook for the component has been updated

Steps to Test

  1. <Hr /> new component is rendered: https://deploy-preview-416--vip-design-system-components.netlify.app/?path=/docs/hr--docs
  2. <Dropdown /> component continues to work as expected now that it was migrated to TS: https://deploy-preview-415--vip-design-system-components.netlify.app/?path=/docs/dropdown--docs
  3. The new migrated component <FilterDropdown /> is working as expected in the demo page: https://deploy-preview-416--vip-design-system-components.netlify.app/?path=/docs/filterdropdown--docs

Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for vip-design-system-components ready!

Name Link
🔨 Latest commit b9850fc
🔍 Latest deploy log https://app.netlify.com/sites/vip-design-system-components/deploys/667db7f4a523120008dec416
😎 Deploy Preview https://deploy-preview-416--vip-design-system-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@djalmaaraujo djalmaaraujo force-pushed the migrate/common-packages branch from f6493bb to d5f70f1 Compare June 26, 2024 21:07
@djalmaaraujo djalmaaraujo changed the title Component Migration: Dropdown, FilterDropdown Component Migration: Dropdown, FilterDropdown, Page, Hr Jun 26, 2024
@djalmaaraujo djalmaaraujo requested review from t-wright and a team June 27, 2024 19:00
@djalmaaraujo djalmaaraujo marked this pull request as ready for review June 27, 2024 19:00
@djalmaaraujo djalmaaraujo merged commit 40b8c70 into trunk Jun 27, 2024
8 checks passed
@djalmaaraujo djalmaaraujo deleted the migrate/common-packages branch June 27, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants