Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce common card padding #429

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Reduce common card padding #429

merged 4 commits into from
Jul 1, 2024

Conversation

djalmaaraujo
Copy link
Contributor

Description

Reduce Card default padding to

Checklist

  • This PR has good automated test coverage
  • The storybook for the component has been updated

Steps to Test

  1. Pull down PR.
  2. npm run dev.
  3. Open http://localhost:6006/?path=/story/card--styled-body
  4. Verify that the body of the card is white, a custom-style
  5. Default padding is now 16px

@djalmaaraujo djalmaaraujo requested review from rebeccahum and a team July 1, 2024 19:57
@netlify Netlify
Copy link

netlify bot commented Jul 1, 2024 •
edited
Loading

✅ Deploy Preview for vip-design-system-components ready!

Name Link
🔨 Latest commit 8cf48b0
🔍 Latest deploy log https://app.netlify.com/sites/vip-design-system-components/deploys/66830afaabe0ec0007c54538
😎 Deploy Preview https://deploy-preview-429--vip-design-system-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@djalmaaraujo djalmaaraujo merged commit 5d277f3 into trunk Jul 1, 2024
8 checks passed
@djalmaaraujo djalmaaraujo deleted the adjust/card-padding branch July 1, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobasto brunobasto brunobasto approved these changes

@rebeccahum rebeccahum Awaiting requested review from rebeccahum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djalmaaraujo @brunobasto