Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadioBoxGroup: Make it responsive #435

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

djalmaaraujo
Copy link
Contributor

Description

I am improving this component to have a responsive behavior.

Before:

image
image

After:

SCR-20240823-pyls
SCR-20240823-pynj
SCR-20240823-pyqc

Checklist

  • This PR has good automated test coverage
  • The storybook for the component has been updated

Steps to Test

  1. Pull down PR.
  2. npm run dev.
  3. Open http://localhost:6006/iframe.html?args=&id=radioboxgroup--default&viewMode=story with a smaller screen, and it should wrap
  4. http://localhost:6006/iframe.html?args=&id=radioboxgroup--default&viewMode=story with a smaller screen, and it should wrap

Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for vip-design-system-components ready!

Name Link
🔨 Latest commit 295652c
🔍 Latest deploy log https://app.netlify.com/sites/vip-design-system-components/deploys/66c8fcb50be552000856b696
😎 Deploy Preview https://deploy-preview-435--vip-design-system-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@djalmaaraujo djalmaaraujo merged commit 73dd514 into trunk Aug 26, 2024
8 checks passed
@djalmaaraujo djalmaaraujo deleted the feat/add-responsiveness-to-radiobox-group branch August 26, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants