-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract the chip variant of radio-box-group to a different component #436
Conversation
✅ Deploy Preview for vip-design-system-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good, but you are duplicating the RadioGroup component, which already supports the Chip variation. Is there a reason we are recreating the component without removing the Chip functionality from the original?
Could adding the size
property to the RadioBoxGroup component be a simpler solution? If you decide to go with a new component for the chip, we need to at least refactor RadioBoxGroup to remove the already-added chip feature.
PS: Since I believe you chose the "new chip component," please ensure that you reuse code from the RadioBoxGroup; otherwise, we might have different or unexpected experiences.
Milestone suggestion:
1 - Remove the current chip feature from RadioBoxGroup
2 - Release the new version of this library
3 - Open a vip-dashboard pull request with both replacements of the currently chip usage, and the new vip-design-system version
Feel free to let me know how I can help.
I will be removing the original chip variant, but was waiting on your opinion first 😄 |
160e0de
to
68b53d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on these changes @aswasif007
Description
Presently we have a
chip
variant of theRadioBoxGroup
component. We are in need for a small size of thischip
variant. But the componentRadioBoxGroup
does not provide any size prop, nor does its other variant need any.So in this PR we are extracting the
chip
variant to a separate componentRadioGroupChip
and adding asize
prop withsmall
andmedium
values.Steps to Test
npm run dev
.