Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO REVIEW REQUIRED AT THIS TIME, DO NOT MERGE] Moving vip-dashboard repository to vip-go-mu-plugins #1875

Closed

Conversation

lyx
Copy link

@lyx lyx commented Nov 19, 2020

Description

Moving vip-dashboard repository files to vip-go-mu-plugins repository. Issue request #90.

https://github.com/Automattic/vip-dashboard/issues/90

Checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally (or has an appropriate fallback).
  • This change works and has been tested on a Go sandbox.
  • This change has relevant unit tests (if applicable).
  • This change has relevant documentation additions / updates (if applicable).

Steps to Test

Outline the steps to test and verify the PR here.

Example:

  1. Check out PR.
  2. Go to wp-admin > Tools > Bakery
  3. Click on "Bake Cookies" button.
  4. Verify cookies are delicious.

@lyx lyx requested a review from a team as a code owner November 19, 2020 21:18
@lyx
Copy link
Author

lyx commented Nov 19, 2020

Checkboxes items:

This change works and has been tested locally (or has an appropriate fallback).
This change works and has been tested on a Go sandbox.
This change has relevant unit tests (if applicable).
This change has relevant documentation additions / updates (if applicable).

Have not be performed yet - does not need review just yet.

@lyx lyx changed the title Moving vip-dashboard repository to vip-go-mu-plugins [NO REVIEW REQUIRED AT THIS TIME] Moving vip-dashboard repository to vip-go-mu-plugins Nov 19, 2020
@lyx lyx changed the title [NO REVIEW REQUIRED AT THIS TIME] Moving vip-dashboard repository to vip-go-mu-plugins [NO REVIEW REQUIRED AT THIS TIME, DO NOT MERGE] Moving vip-dashboard repository to vip-go-mu-plugins Nov 19, 2020
@rinatkhaziev rinatkhaziev marked this pull request as draft November 20, 2020 03:55
@rinatkhaziev
Copy link
Contributor

Thanks for the PR!

If a PR is not ready for review please submit it as a "Draft PR". I just converted it to such so it doesn't ping us for a review.

Additionally, seems there's a rogue .DS_Store in the PR that needs to be removed.

@GaryJones
Copy link
Contributor

The PR also seems to include an update to the submodule, rather than a commit that replaces the submodule with vip-dashboard at the commit the submodule was at. (Adding any new commits from the vip-dashboard package that weren't yet in vip-go-mu-plugins, should be done in a new PR).

@mjangda
Copy link
Member

mjangda commented Nov 20, 2020

I suggest a few different PRs for this:

  1. PR to bump the submodule to the latest version (merge + deploy)
  2. PR to remove the submodule (merge, no deploy)
  3. PR to add the plugin as-is, i.e. no submodule (merge, shouldn't need deploy)

As part of 3 we may need to look at the build process since there's some grunt build steps involved, I believe. If it's a lot of effort to integrate, it might be better just to leave it as-is for now since the plugin doesn't change much (although, that could change in the future).

@rinatkhaziev
Copy link
Contributor

Superseded by #2078 and #2079

@rinatkhaziev rinatkhaziev deleted the issue/90_vip-dashboard_repo_move_this_to_mu-plugins branch April 23, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants