Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Remote-Follow improvements #805

Merged
merged 9 commits into from
Jul 15, 2024
Merged

Some Remote-Follow improvements #805

merged 9 commits into from
Jul 15, 2024

Conversation

pfefferle
Copy link
Member

@pfefferle pfefferle commented Jul 11, 2024 •
edited
Loading

Fixes:

  •  use correct class name
  • save fediverse handle in remote follow widget <- @mattwiebe Awesome 🎉
  • improve CSS
  • fix build pipeline <- @mattwiebe can you help fixing the build pipeline? @mattwiebe Thanks for fixing it!

CSS Improvements

Mainly the search fields:

Screenshot 2024-07-12 at 09 30 16

The reply link:

Screenshot 2024-07-12 at 09 55 02

@pfefferle pfefferle changed the title Some lightbox improvements Some Remote-Follow improvements Jul 12, 2024
pfefferle and others added 2 commits July 12, 2024 08:16
@pfefferle
Merge branch 'master' into improve/remote-follow
9e458a4
@mattwiebe @pfefferle
Remember remote profile (#807)
8f1e784 
* Revert to @wordpress/scripts@27

* Remember users

* whitespace

* buncha class should be className

* render -> createRoot

* build

---------

Co-authored-by: Matthias Pfefferle <pfefferle@users.noreply.github.com>
@pfefferle
Copy link
Member Author

@mattwiebe I merged your PR into this branch, to be able to easier improve the CSS.

@pfefferle
Copy link
Member Author

pfefferle commented Jul 12, 2024 •
edited
Loading

@mattwiebe because the remote-follow and the remote-comment overlay share the same dialog (dialog.js), the checkbox also shows in the remote-follow overlay.

Update: I think I fixed it!

Screenshot 2024-07-12 at 08 55 15

@pfefferle pfefferle marked this pull request as ready for review July 12, 2024 07:56
@pfefferle pfefferle requested a review from mattwiebe July 12, 2024 08:22
@pfefferle pfefferle merged commit 2e90d76 into master Jul 15, 2024
21 checks passed
@pfefferle pfefferle deleted the improve/remote-follow branch July 15, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwiebe mattwiebe Awaiting requested review from mattwiebe

Assignees
No one assigned
Labels
[Block] Follow Me [Block] Followers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pfefferle @mattwiebe