Show '⁂ Fediverse Preview' link in Row-Actions #989
Conversation
pfefferle
commented
Nov 13, 2024
•
pfefferle
commented
|
I'm not sure I'd understand that that's meant to be an Activitypub Preview, until a few days ago I was unaware of the logo. Is this something other plugins offer as well in the list view? |
|
Good question... The icon is still pretty new... 🤔 I thought it might be nice to be as short as possible... do you think it should be |
pfefferle
changed the title
|
My preview looks like this, is that a configuration issue? 
|
|
It's not part of this PR but would be a good follow up, the preview link looks off with the Core preview: 
|
I saw this is already reported somewhere in the core-editor repo, but can't find it any more. The "Preview in new tab" seems to be not aligned with the top links and the fediverse links. I am not sure if we can do something there. |
How have you done that!?! 😱 |
|
I personally don't think a preview link is necessary in the list view. It makes more sense to me where it is now, in the Preview dropdown when editing a post. |
|
We had some feedbacks from people with the classic editor, that they can't use it now and because the list also includes the classic preview link... |
That is a nice one! |
| @@ -811,7 +811,8 @@ public static function row_actions( $actions, $post ) { | |||
| ! \post_type_supports( \get_post_type( $post ), 'activitypub' ) || | |||
| ! in_array( $post->post_status, array( 'pending', 'draft', 'future', 'publish' ), true ) || | |||
| ! \current_user_can( 'edit_post', $post->ID ) || | |||
| ACTIVITYPUB_CONTENT_VISIBILITY_LOCAL === get_content_visibility( $post ) | |||
| ACTIVITYPUB_CONTENT_VISIBILITY_LOCAL === get_content_visibility( $post ) || | |||
| site_supports_blocks() | |||
There was a problem hiding this comment.
@pfefferle Are you interested in having more fine control here? Sometimes plugins offering custom post types to also not use the block editor yet for their post types, so whether the button is shown could be depending on that as well.
There was a problem hiding this comment.
@Menrath sure, can you create a PR for that?
