Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload the page to clear the state #77181

Closed
wants to merge 1 commit into from

Conversation

karenroldan
Copy link
Contributor

@karenroldan karenroldan commented May 19, 2023

Related to #70674

Proposed Changes

With the addition of reload in the login page, the execution time wasn't significantly impacted. The average execution time remains similar to the average time I observed without the reload.

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@github-actions
Copy link

github-actions bot commented May 19, 2023

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@karenroldan karenroldan marked this pull request as ready for review May 19, 2023 17:17
@karenroldan karenroldan requested review from a team and worldomonation as code owners May 19, 2023 17:17
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 19, 2023
@worldomonation
Copy link
Contributor

@karenroldan Ah shoot, I was experimenting with this as well.

I think we should try merging yours in first, and then reverting the changes @dpasque made in #75436 to re-expose instances of this failure. What do you think?

@@ -31,6 +31,8 @@ export class LoginPage {
status: 200,
} );
} );
// Reload the page to clear the state.
await this.page.reload();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question:non-blocking - my interpretation of microsoft/playwright#18137 (comment) is that the page reload should come after the login process, but before the navigation to the target URL.

@karenroldan
Copy link
Contributor Author

Sorry for the late response! I just saw this comment today. After syncing with @worldomonation, we've decided to close this ticket and carry on our efforts to investigate further and find the root cause of the initial issue. We'll park this change for now! 👍🏻

@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants