-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Migration: Default to hiding the migration trial from unverified users #90589
Site Migration: Default to hiding the migration trial from unverified users #90589
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on both scenarios work fine. LGTM!
Proposed Changes
We've decided to default to hiding the migration free trial from unverified users across all migration flows. This behavior can be overridden by passing the
data
parameter tonavigate
.Testing Instructions
As a logged in a verified user, go to
/start
.Proceed through the migration flow.
On the Upgrade Plan step, verify that you have the option for a 7-day trial.
As a new, unverified user, go to
/start
.Proceed through the migration flow.
On the Upgrade Plan step, verify that you do not have the option for a 7-day trial. You should only see "Upgrade and migrate"/
Pre-merge Checklist