Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Site Migration: Default to hiding the migration trial from unverified users" #90595

Merged

Conversation

markbiek
Copy link
Contributor

Reverts #90589

Seeing some weird test failures so I'm reverting to debug.

Copy link

github-actions bot commented May 10, 2024

Link to live branch is being generated...
Please wait a few minutes and refresh this page.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug revert-90589-update/migration-hide-trial-for-unverified-users on your sandbox.

@markbiek markbiek self-assigned this May 10, 2024
@markbiek markbiek merged commit 6625c6f into trunk May 10, 2024
9 of 12 checks passed
@markbiek markbiek deleted the revert-90589-update/migration-hide-trial-for-unverified-users branch May 10, 2024 17:37
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1 bytes added 📈 [gzipped])

name              parsed_size           gzip_size
migration-signup        +47 B  (+0.1%)       +1 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants