LogError only pushes to db and posts to Slack if not dev

AuxStudio · Jul 1, 2018 · 892276c · 892276c
1 parent 8a3aa3c
commit 892276c
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 26 deletions.
diff --git a/sagas/errors/logError/__tests__/logError.test.js b/sagas/errors/logError/__tests__/logError.test.js
@@ -25,13 +25,7 @@ describe('logError saga', () => {
     it('should have yielded all of our actions', (result) => {
       expect(result).toEqual(
         all([
-          put({
-            type: 'pushData',
-            payload: {
-              data,
-              ref: 'errors',
-            },
-          }),
+          // NOTE: Since, __DEV__, pushData should not be called
           put({
             type: 'SET_SYSTEM_MESSAGE',
             payload: {
@@ -56,13 +50,6 @@ describe('logError saga', () => {
     it('should have yielded all of our actions', (result) => {
       expect(result).toEqual(
         all([
-          put({
-            type: 'pushData',
-            payload: {
-              data,
-              ref: 'errors',
-            },
-          }),
           put({
             type: 'SET_SYSTEM_MESSAGE',
             payload: {

diff --git a/sagas/errors/logError/index.js b/sagas/errors/logError/index.js
@@ -6,9 +6,13 @@ import config from '../../../config';
 export default function* logError(action) {
   /*
       This should
-        - Log the error to the db
-        - SET_SYSTEM_MESSAGE
-        - Post it to Slack if Slack config has been set up
+        - If in production:
+          - Log the error to the db
+          - SET_SYSTEM_MESSAGE
+          - If Slack config has been set up
+            - Post to Slack
+        - If in development
+          - SET_SYSTEM_MESSAGE
   */
 
   try {
@@ -20,13 +24,6 @@ export default function* logError(action) {
     };
 
     const actions = [
-      put({
-        type: 'pushData',
-        payload: {
-          data,
-          ref: 'errors',
-        },
-      }),
       put({
         type: 'SET_SYSTEM_MESSAGE',
         payload: {
@@ -35,6 +32,15 @@ export default function* logError(action) {
         error: true,
       }),
     ];
+
+    const databaseAction = put({
+      type: 'pushData',
+      payload: {
+        data,
+        ref: 'errors',
+      },
+    });
+
     const slackAction = put({
       type: 'post',
       payload: {
@@ -49,8 +55,12 @@ export default function* logError(action) {
       },
     });
 
-    if (config.slack.webhook) {
-      actions.push(slackAction);
+    if (!__DEV__) {
+      actions.push(databaseAction);
+
+      if (config.slack.webhook) {
+        actions.push(slackAction);
+      }
     }
 
     yield all(actions);