Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new checker for repository_type field on GlobalConfig #132

Closed
bobbyshermi opened this issue May 1, 2023 · 2 comments
Closed

Add new checker for repository_type field on GlobalConfig #132

bobbyshermi opened this issue May 1, 2023 · 2 comments
Labels
good first issue New-contributor friendly 📈 Improvement Improvement of a feature. 🟩 Priority: Low Low priority and doesn't need to be rushed

Comments

@bobbyshermi
Copy link
Contributor

It would be great to have a checker on the value of the repository_type field in GlobalAppConfig.

It can raise an error if the repository_type is unknown (sql or filesystem). Something like.

    def _check_repository_type(self, global_config: GlobalAppConfig):
        value = global_config.repository_type
        if value != "filesystem" and value != "sql":
            self._error(
                global_config._REPOSITORY_TYPE_KEY,
                value,
                f"unknown value: {value} for field {global_config._REPOSITORY_TYPE_KEY}.",
            )
@FlorianJacta
Copy link
Member

Thank you for your issue! The current behavior is that any repository_type different from “sql” and “filesystem” will eventually be “filesystem” (the default value). If this checker is added, then this behavior should also be changed.

The Taipy Core team will look through this issue and answer it.

@jrobinAV jrobinAV added 📈 Improvement Improvement of a feature. good first issue New-contributor friendly 🟩 Priority: Low Low priority and doesn't need to be rushed labels May 2, 2023
@jrobinAV
Copy link
Member

jrobinAV commented May 2, 2023

Issue moved to Avaiga/taipy-config #61 via Zenhub

@jrobinAV jrobinAV closed this as completed May 2, 2023
joaoandre-avaiga added a commit that referenced this issue Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue New-contributor friendly 📈 Improvement Improvement of a feature. 🟩 Priority: Low Low priority and doesn't need to be rushed
Projects
None yet
Development

No branches or pull requests

3 participants