-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created a new visual element - progress bar #1303
Created a new visual element - progress bar #1303
Conversation
I don't understand what you're trying to do ? |
|
No problem at all, I suppose I should be more clear. What I'd like is that 2 progress can be rendered side by side The declaration in index.ts and factory.py allows to manually test the component and it's interaction with taipy. |
@FredLL-Avaiga, I've removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getting there
can you mark the discussions as resolved when they are ? |
Made the changes @FredLL-Avaiga , could you please review those👍 |
@FredLL-Avaiga, could you please review the changes in the |
@FredLL-Avaiga, could you please review the changes in my latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Thanks for the review, @FredLL-Avaiga . Also, do I've to add the Progress.spec.tsx file (like the tests)? I haven't added those yet. |
yes you do |
@FredLL-Avaiga, I've created the tests file, but I'm not able to understand that how to add the tests completely. Could you please guide that what has to be put in here, like in the |
Jest emulates a user Interaction. Once you get an element you can interact with it like a user would: click, type ... I'm not sure it's the best for your use case. But you can at least render the component and verify that everything shows as it should depending on the properties. I suppose you can look at the indicator component for an example |
Ohh, yes! I just realized that. I apologize for my mistake. I copied the |
Added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I'll invite @FabienLelaquais to review it and if he agrees I'll merge your PR |
Thank you so much for your help to me complete this PR @FredLL-Avaiga 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job.
A few minor changes requested in the doc, and I suspect incomplete tests...
Hey @FabienLelaquais, ig there's some miscommunication, actually, in the above suggestions and also in the latest commit which I've made, the default value of |
Now I think everything is working fine @FabienLelaquais @FredLL-Avaiga ? I've set the default value of |
@FabienLelaquais @FredLL-Avaiga , any update on this :) |
Sure. I had to talk with the team for opinion, and make a decision. Let me now look at the changes and hopefully approve! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the last changes seem ok to me!
Well done, and thank you!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Fixes #692
About
This PR creates a new progress bar visual element to be incorporated in Taipy.