-
Notifications
You must be signed in to change notification settings - Fork 70
feat(AvCheckboxGroup): add support for checkbox groups #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a styling issue when the checkbox groups are invalid.
Also, can you alias minChecked
and maxChecked
to be min
and max
as props on the AvCheckboxGroup
(or just modify the existing min
/max
validations to work with arrays) to allow for something like:
<AvCheckboxGroup name="checkboxExample" label="U Pick 2!" max="2" min="2" required>
<AvCheckbox label="Bulbasaur" value="Bulbasaur" />
<AvCheckbox label="Squirtle" value="Squirtle" />
<AvCheckbox label="Charmander" value="Charmander" />
<AvCheckbox label="Pikachu" value="Pikachu" disabled />
</AvCheckboxGroup>
@TheSharpieOne good catch! |
I will update the aliasing. Also, I'll change the styling. |
@TheSharpieOne I pushed a couple commits to address the issues you mentioned. When you have time, please take another look and let me know what you think. |
Deploy preview for availity-reactstrap-validation ready! Built with commit 6db1f46 https://deploy-preview-106--availity-reactstrap-validation.netlify.com |
The min and max checked validation also have the style issue. Not sure the best way to handle this as this is where it really starts to get different from radios. |
Thanks for your feedback. I'll dig into the code and come up with an appropriate fix. |
@TheSharpieOne The Also, thanks for bearing with me. I just learned React for the sake of updating this library. Is there anything else you want me to add/change before the merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.