This repository was archived by the owner on Feb 21, 2023. It is now read-only.
fix(BlockUI): allow tag to be components #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove ref from the wrapper element to allow wrapper to be any component (not just DOM elements) the ref is now on the overlay which is the same height and width as the wrapper allowing the keepInView logic to work the same. fixes #8
|
Deploy preview for react-block-ui ready! Built with commit 065f592 |
Closed
GoPro16
approved these changes
Jun 18, 2019
|
github really wants me to know this: |
|
@GoPro16 or @robmcguinness, one of you mind creating a new release and publishing it 🙏🙏🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove ref from the wrapper element to allow wrapper to be any component (not just DOM elements)
the ref is now on the overlay which is the same height and width as the wrapper (per styling) allowing the keepInView logic to work the same.
fixes #8
Note: If we do want want to depend on styling (incase someone overrides the styles to make the overlay different), we can use the tab helpers which appear before and after the blocked content as mentioned in #8 (comment). If this is the case, a new PR can be made.