Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Ported library to Python 3 #202

Closed
wants to merge 6 commits into from
Closed

[WIP] Ported library to Python 3 #202

wants to merge 6 commits into from

Conversation

tricoder42
Copy link
Contributor

⚠️ Work in progress, do not merge 💣

Compatability issues with Python 2/3:

  • random.choice doesn't respect random.seed. random.random produces the same numbers for given seed for both Python 2 and 3, but random.choice doesn't select the same elements from list. Following snippet produces different output in Python 2 and 3:
    import random
    random.seed(10)
    print([random.choice(['C', 'D']) for i in range(20)])

Some strategies relies on random choices. Right now the tests fail for QLearner

@drvinceknight
Copy link
Member

Given @marcharper's work on #264 can we close this PR?

@tricoder42
Copy link
Contributor Author

Yep :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants