More refactoring of payoff.py and cooperation.py #410
Merged
+69
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge this. I've changed my mind about the scores_matrix function. It means the payoff gets calculated twice and I don't like that! I'm going to get rid of it. |
There was a problem hiding this comment.
Worth including some edge cases? A single player etc...?
There was a problem hiding this comment.
Yeah, probably! I'll think of something to add
|
done! |
|
I'm happy with this. 👍 |
|
No excuses left now. I'm going to have tackle the ripping apart of Round Robin etc. to get the interactions out! |
|
😨 💪 |
|
looks good to me, @meatballs just checking that the don't merge comment above no longer applies? |
|
@marcharper correct. I removed my own code that was causing me offence! |
marcharper
added a commit
that referenced
this pull request
Nov 3, 2015
More refactoring of payoff.py and cooperation.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds player_count function to derive number of players from interactions dictionary