Skip to content

Conversation

meatballs
Copy link
Member

No description provided.

Copy link
Member

@drvinceknight drvinceknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me: just the one question about gitignoring the eggs dir as opposed to having a file in it.

@@ -0,0 +1,6 @@
This directory contains eggs that were downloaded by setuptools to build, test, and run plug-ins.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not just gitignore this directory?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't notice that creep in there. I'll sort it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm..... our .gitignore looks a little light. Perhaps another PR coming shortly......

@marcharper
Copy link
Member

Looks fine to me, can you rebase onto the new master?

@marcharper marcharper merged commit f1a45c0 into master Oct 29, 2016
@marcharper marcharper deleted the tidytitfortat branch November 11, 2016 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants