Add type hints to alternator #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if it's enough to type hint the parent class ( |
|
@marcharper that is what I thought too. Seems like the issue we face for |
|
I think testing for |
marcharper
reviewed
Jan 31, 2017
| @@ -17,7 +18,7 @@ class Alternator(Player): | |||
| 'manipulates_state': False | |||
| } | |||
|
|
|||
| def strategy(self, opponent): | |||
| def strategy(self, opponent: axelrod.player.Player) -> axelrod.actions.Action: | |||
There was a problem hiding this comment.
Just Player is fine here since you imported it; you can import Action from axelrod.actions and then there's no need to import axelrod in line 2.
marcharper
approved these changes
Jan 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#808
@drvinceknight @meatballs. Please review.