Skip to content

Remove two random samples for hypothesis. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2017
Merged

Conversation

drvinceknight
Copy link
Member

hypothesis by default randomly samples 200 experiments, as 2 of our
variables have the option of 2 values this is wasted. I've removed them
from the given calls and just included the 4 cases in a loop.

FWIW, I've just run this with and it's passed 5 times in a row and then hypothesis found an actual failing case:

k48r returned -1
...
Falsifying example: test_original_strategy(move_number=159, my_score=0, their_score=0)

That indicates that k48r might do something strange or perhaps it plays in such a way that it knows that it's not possible that move number 159 results in a score pair of 0, 0? (For example perhaps it knows that someone would have defected by move number 159...)

hypothesis by default randomly sample 200 experiments, as 2 of our
variables have the option of 2 values this is wasted. I've removed them
from the `given` calls and just included the 4 cases in a loop.
@meatballs meatballs merged commit a5bdd53 into master Jul 25, 2017
@meatballs meatballs deleted the simpler-hyp-test branch July 25, 2017 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants