Skip to content

Conversation

fdev31
Copy link
Contributor

@fdev31 fdev31 commented Jul 26, 2025

WIP code, know problems:

  • very dirty code, high chance of dead code etc... it's the first version I'm happy with after trying a lot of things
  • chance of unneeded changes
  • proper initialization / initial state is missing
  • didn't test non-icons or vertical mode

Sorry for this PR ;)

@Axenide
Copy link
Owner

Axenide commented Sep 17, 2025

imagen

I'm testing this and the workspaces seem broken. I can almost see the elastic effect when using the default ones, but with a transparent color, or black, I don't really know. There is that primary colored thing that I assume is the elastic highlight?

@fdev31
Copy link
Contributor Author

fdev31 commented Sep 17, 2025

This version should be more robust

@fdev31
Copy link
Contributor Author

fdev31 commented Sep 17, 2025

I think it's broken after rebase, I've fixed it locally but will better test tomorrow.

@fdev31 fdev31 force-pushed the fancyworkspaces branch 2 times, most recently from 5ee7d8d to 3e0b494 Compare September 18, 2025 16:07
@fdev31
Copy link
Contributor Author

fdev31 commented Sep 18, 2025

Please give it another try when you have time, it's really robust now, at least for me.

@fdev31
Copy link
Contributor Author

fdev31 commented Sep 18, 2025

When no label is used, it's not looking great (position are not matching the expectation). I suggest it could just be the same as the "icon" mode using " " as an icon, or something like this... I'm pushing a last commit to make things more consistent, but I didn't check anything vertical for now.

@fdev31
Copy link
Contributor Author

fdev31 commented Sep 18, 2025

Multi-monitor is still kind of broken but less than the current main branch in my case... I think it would require a bigger refactor regarding the event handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants