Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Conversation

tobiaslilja2
Copy link
Contributor

Fixed an issue with being able to click outside of the checkbox to trigger a toggle.

Describe your changes

Changed the width in the Checkbox component to be auto instead of fixed 100%

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@tobiaslilja2 tobiaslilja2 requested a review from Tigge as a code owner January 9, 2023 12:19
Copy link
Collaborator

@boilund boilund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you just add Fixes: #252 in your commit message?

Fixed an issue with being able to click outside of the checkbox to trigger a toggle.

Fixes: AxisCommunications#252
@tobiaslilja2 tobiaslilja2 force-pushed the tobiali/fix/checkboxWrapper branch from 6757f37 to e1a9d7e Compare February 24, 2023 08:44
@tobiaslilja2 tobiaslilja2 requested review from boilund and removed request for Tigge February 27, 2023 07:57
@boilund boilund merged commit d20f6f9 into AxisCommunications:main Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox with label fills all available space
2 participants