Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Conversation

Sana-Shana
Copy link
Contributor

Describe your changes

Add a new icon - SystemTimelocationIcon

Please include a summary of the change, a relevant motivation and context.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@Sana-Shana Sana-Shana requested a review from Tigge as a code owner June 26, 2023 09:20
@boilund
Copy link
Collaborator

boilund commented Jun 28, 2023

Also if the icon is based on any material icon, add a comment above the svg code.

@Sana-Shana Sana-Shana force-pushed the 5363-location-icon branch from facfdd3 to c4a4121 Compare June 28, 2023 10:57
@Sana-Shana
Copy link
Contributor Author

Also if the icon is based on any material icon, add a comment above the svg code.

We got the icon from UX Alba Salgado. We checked the Google material icons as well, but we didn't find it there.

@Sana-Shana Sana-Shana requested a review from boilund June 28, 2023 11:00
@boilund
Copy link
Collaborator

boilund commented Jun 28, 2023

Also if the icon is based on any material icon, add a comment above the svg code.

We got the icon from UX Alba Salgado. We checked the Google material icons as well, but we didn't find it there.

I checked material icons as well, and I think your icon is based on this icon.

2023-06-28_13-02

@Sana-Shana
Copy link
Contributor Author

Sana-Shana commented Jun 28, 2023

Also if the icon is based on any material icon, add a comment above the svg code.

We got the icon from UX Alba Salgado. We checked the Google material icons as well, but we didn't find it there.

I checked material icons as well, and I think your icon is based on this icon.

2023-06-28_13-02

Thank you so much, I updated the code : )

@Sana-Shana Sana-Shana force-pushed the 5363-location-icon branch from c4a4121 to 7beef1a Compare June 28, 2023 11:25
@boilund boilund merged commit c3bfb9b into AxisCommunications:main Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a new icon - SystemTimelocation icon

2 participants