feat: human readable time format #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
=======================================
Coverage 100% 100%
- Complexity 21 26 +5
=======================================
Files 2 2
Lines 46 54 +8
=======================================
+ Hits 46 54 +8
Continue to review full report at Codecov.
|
|
This is awesome, thank you. I'm on my phone, but this looks great. I will merge as soon as I get back. Thanks again for this PR. |
|
No worries :) |
|
Thanks again for the PR. I have merged it. I will start working on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #2 the human format was not implemented.
This implements that, I grabbed the conversion function from PHPunit.
Tests updated as well :)