Skip to content

Adding the todolist endpoints #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Adding the todolist endpoints #34

merged 1 commit into from
Jul 13, 2021

Conversation

yoelhor
Copy link
Contributor

@yoelhor yoelhor commented Jul 13, 2021

Purpose

This PR:

  1. Adds the .NET Core To do list endpoints, to align with other Azure AD B2C client samples. With this change the developer can choose between using the .NET core or node.js sample (todolist.js and index.js).
  2. Adds a public endpoint which helps with the debugging process (index.js).
  3. Fix CORS issues (index.js)
  4. Change the app settings to validate the issuer name (config.json).

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Read the active-directory-aspnetcore-webapp-openidconnect-v2 guidance. Then change the Angular sample to use this endpoint (instead of the .NET Core one). The ToDoList endpoint URI can be found here.

@yoelhor yoelhor merged commit 5298361 into master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant