chore(infra): update to latest azd infra templates (closes #130) #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| bypass: 'AzureServices' | ||
| defaultAction: 'Allow' | ||
| } | ||
| networkAcls: networkAcls |
Check failure
Code scanning / templateanalyzer
Configure Azure Storage firewall.
|
DO NOT merge for now, provisioning and deployment works fine, but there's now a CORS error. Something seems to be missing in the updated templates |
|
PR is now ready to merge, everything has been fully deployed and tested. |
manekinekko
reviewed
Mar 7, 2024
| @@ -13,7 +14,7 @@ resource web 'Microsoft.Web/staticSites@2022-03-01' = { | |||
| tags: tags | |||
| sku: sku | |||
| properties: { | |||
| provider: 'SwaCli' | |||
| provider: 'Custom' | |||
There was a problem hiding this comment.
No, this is what they use now in all AZD templates. I think the SWACLI provided is set by the CLI directly when deployed
|
@manekinekko I updated the PR to disabled public blob access in the main bicep file, should be good now |
manekinekko
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
App insights is now enabled by default, as part of the newer templates.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?