Skip to content

Conversation

sharifrahaman
Copy link
Contributor

Purpose

  • Move Entra related configurations to oAuthConfig file

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@sharifrahaman sharifrahaman requested a review from Copilot August 18, 2025 21:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors Entra-related configuration by extracting hardcoded credential values from the webpack configuration into a centralized oAuthConfig file, improving maintainability and configuration management.

  • Moves Entra credential configuration (tenantId, clientId, resourceEndpoint) from hardcoded values to a dedicated configuration object
  • Centralizes authentication-related configurations in the oAuthConfig file
  • Updates the webpack configuration to use the new centralized configuration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Project/webpack.config.js Imports the new entraCredentialConfig and replaces hardcoded credential strings with configuration values
Project/oAuthConfig.js Adds the entraCredentialConfig object containing Entra credentials and exports it alongside existing auth configurations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

const entraCredentialConfig = {
tenantId: 'ENTER_TENANT_ID',
clientId: 'ENTER_CLIENT_ID',
resourceEndpoint: 'ACS_RESOURCE_ENDPOINT' // e.g., 'https://contoso.unitedstates.communication.azure.com/'
Copy link
Preview

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment example URL ends with a trailing slash while the placeholder value 'ACS_RESOURCE_ENDPOINT' doesn't. For consistency, either add a trailing slash to the placeholder or remove it from the example URL.

Suggested change
resourceEndpoint: 'ACS_RESOURCE_ENDPOINT' // e.g., 'https://contoso.unitedstates.communication.azure.com/'
resourceEndpoint: 'ACS_RESOURCE_ENDPOINT' // e.g., 'https://contoso.unitedstates.communication.azure.com'

Copilot uses AI. Check for mistakes.

@sharifrahaman sharifrahaman merged commit d3b1963 into main Aug 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants