Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code from container #52

Open
john0isaac opened this issue Jun 28, 2024 · 2 comments · May be fixed by #56
Open

Remove unused code from container #52

john0isaac opened this issue Jun 28, 2024 · 2 comments · May be fixed by #56

Comments

@john0isaac
Copy link

Description

Currently, we are zipping the whole src folder and uploading it to the container.
The code in the frontend/ folder is not needed after we compile the static folder.

Proposal

[Option 1] Move the frontend folder outside of the src folder

[Option 2] Restructure src folder to this:

src
│
└─── frontend
│    .....
└─── backend
    │    .dockerignore
    │    Dockerfile
    │    .....
    └─── fastapi_app
         │    .....
         └─── static

Then use backend folder in azure.yaml

@pamelafox
Copy link
Contributor

Ah right, that looks like what we do for https://github.com/Azure-Samples/azure-search-openai-demo/tree/main/app, probably a good idea.

@john0isaac
Copy link
Author

Yeah, option 2 is based of the ai-search sample. will do a pr for it then

@john0isaac john0isaac linked a pull request Jun 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants