Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azd template #14

Merged
merged 23 commits into from
May 21, 2024
Merged

Add azd template #14

merged 23 commits into from
May 21, 2024

Conversation

justinyoo
Copy link
Contributor

@justinyoo justinyoo commented May 6, 2024

This PR is:

  • To add azd template
  • To update README based on the azd template
  • To add GitHub Actions workflow
  • To change config.json to config.example so that it can be locally used and become CI/CD pipeline friendly

Please do SQUASH merge

@justinyoo justinyoo marked this pull request as ready for review May 7, 2024 05:11
@pierceboggan
Copy link
Contributor

I tried the following combinations:

Existing API Center, new portal - Works great!

New API Center, new portal - Works great!

image

Enhancement: It would be nice to not have to provide the API Center location for the existing API Center scenario (can it be determined from the API Center service name and resource group name?).

There are a few other things that need to be cleaned up before I can merge. Our documentation on Microsoft Learn assumes you are using config.json, and the local debug scenario also assumes config.json is the file name. Can you submit a PR to clean up the Learn documentation as well?

Other than the impact of renaming config.json to config.example, the AZD portions of this PR LGTM!

justinyoo added a commit to justinyoo/azure-docs that referenced this pull request May 19, 2024
- It's based on the change in the PR, Azure/APICenter-Portal-Starter#14
@justinyoo
Copy link
Contributor Author

Enhancement: It would be nice to not have to provide the API Center location for the existing API Center scenario (can it be determined from the API Center service name and resource group name?).

@pierceboggan I've updated the main.bicep to limit the main resource location to the available APIC locations. Devs now can choose the main locations for the new or existing APIC instance.

There are a few other things that need to be cleaned up before I can merge. Our documentation on Microsoft Learn assumes you are using config.json, and the local debug scenario also assumes config.json is the file name. Can you submit a PR to clean up the Learn documentation as well?

This has been updated in this README. In addition to that, another PR for Microsoft Learn has been created to the other repo.

@pierceboggan
Copy link
Contributor

Docs are now merged, so merging this PR too.

@pierceboggan pierceboggan self-requested a review May 21, 2024 18:03
@pierceboggan pierceboggan merged commit 0a2c038 into Azure:main May 21, 2024
1 check passed
@justinyoo justinyoo deleted the feature/azdevfy branch May 22, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants