Skip to content

Replace rightshift with math.pow #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

Replace rightshift with math.pow #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/ConfigurationClientWrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { AppConfigurationClient } from "@azure/app-configuration";

const MaxBackoffDuration = 10 * 60 * 1000; // 10 minutes in milliseconds
const MinBackoffDuration = 30 * 1000; // 30 seconds in milliseconds
const MAX_SAFE_EXPONENTIAL = 30; // Used to avoid overflow. bitwise operations in JavaScript are limited to 32 bits. It overflows at 2^31 - 1.
const JITTER_RATIO = 0.25;

export class ConfigurationClientWrapper {
Expand Down Expand Up @@ -36,8 +35,8 @@ export function calculateBackoffDuration(failedAttempts: number) {
}

// exponential: minBackoff * 2 ^ (failedAttempts - 1)
const exponential = Math.min(failedAttempts - 1, MAX_SAFE_EXPONENTIAL);
let calculatedBackoffDuration = MinBackoffDuration * (1 << exponential);
// The right shift operator is not used in order to avoid potential overflow. Bitwise operations in JavaScript are limited to 32 bits.
let calculatedBackoffDuration = MinBackoffDuration * Math.pow(2, failedAttempts - 1);
if (calculatedBackoffDuration > MaxBackoffDuration) {
calculatedBackoffDuration = MaxBackoffDuration;
}
Expand Down