Secret refresh bug fix #218
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiyuanliang-ms
force-pushed
the
zhiyuanliang/secret-refresh-bug-fix
branch
from
ab8e567 to
a7087cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is found due to the discussion here.
Corner case:
If there are a secret reference and a normal configuration setting with the same key (but different labels), the expected behavior is that if the normal configuration setting is loaded later, it should override the secret value. However, the current implementation will let the secret value to override it when secret refresh is enabled.
The fix is to dedupe the configuration settings with the same key in advance (before processing all configuration settings). In this case, if a secret reference is overrided by a normal key value it will not be stored in cache for the following secret refresh operation.