Skip to content

Conversation

benank
Copy link
Contributor

@benank benank commented Mar 11, 2022

  • Fixes code coverage comments in PRs (see below)
  • Blocks merging PRs if coverage goes down (any code added must have UTs)
  • Adds Python 2.7 code coverage (unsure of how this is working right now - will require more time later to investigate)
  • Does not block merging if tests are failing - will need to investigate more on that later

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@8392668). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #120   +/-   ##
=========================================
  Coverage          ?   80.05%           
=========================================
  Files             ?       86           
  Lines             ?    11549           
  Branches          ?        0           
=========================================
  Hits              ?     9246           
  Misses            ?     2303           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8392668...6540c83. Read the comment docs.

@benank benank requested review from a team, kjohn-msft and rane-rajasi and removed request for a team March 11, 2022 20:18
@benank benank requested a review from kjohn-msft March 11, 2022 21:24
@benank benank merged commit adc2192 into master Mar 11, 2022
@benank benank deleted the bankiel-codecov-improvements branch March 11, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants