Add extra checks for Python path in startup script #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 16, 2022 13:19
benank
requested review from
a team,
kjohn-msft and
rane-rajasi
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
=======================================
Coverage 80.64% 80.64%
=======================================
Files 86 86
Lines 11631 11631
=======================================
Hits 9380 9380
Misses 2251 2251 Continue to review full report at Codecov.
|
kjohn-msft
reviewed
Mar 16, 2022
| echo "No Python interpreter found on the box" >&2 | ||
| exit 51 # Not Supported | ||
| echo "Python is required, but no Python interpreter was found on the box" >&2 | ||
| exit 52 |
There was a problem hiding this comment.
What's the error code mapping for 52? Please leave that as a comment as before in the code.
There was a problem hiding this comment.
Error code mapping for 52 is missing dependency; error code 51 is unsupported OS. Added link with more information in comment.
kjohn-msft
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds extra checks for Python in case it isn't in the path/environment variables.
Also changes exit code 51 to exit code 52, according to the Extensions Best Practices page. (missing dependency instead of unsupported OS)